[scripts] Update generate-artifacts-executor script to account for optional output path
#54609
+44
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…optional The argument for the output path was always optional. This wasn't reflected in types, however, so this was missed in two prior changes.
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
kitten
force-pushed
the
@kitten/fix/optional-base-output-path
branch
from
b64d3f9 to
397b02c
Compare
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this in D87456501. |
cipolleschi
requested changes
Nov 21, 2025
Contributor
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
Thanks for the fix. I left a few suggestions and a couple of questions.
...ages/react-native/scripts/codegen/generate-artifacts-executor/generateReactCodegenPodspec.js
Outdated
Show resolved
Hide resolved
...ages/react-native/scripts/codegen/generate-artifacts-executor/generateReactCodegenPodspec.js
Outdated
Show resolved
Hide resolved
| const relativeAppPath = | ||
| outputPath != null && outputPath.length > 0 | ||
| ? path.relative(outputPath, appPath) | ||
| : ''; |
Contributor
There was a problem hiding this comment.
So if outputPath is not passed, the relativeAppPath is '.'?
Are we sure it is correct?
Comment on lines
+87
to
+90
| const relativeReactNativeRootFolder = | ||
| outputPath != null && outputPath.length > 0 | ||
| ? path.relative(outputPath, REACT_NATIVE_PACKAGE_ROOT_FOLDER) | ||
| : ''; |
Contributor
There was a problem hiding this comment.
So if outputPath is not passed, the relativeAppPath is '.'?
Are we sure it is correct?
packages/react-native/scripts/codegen/generate-artifacts-executor/index.js
Outdated
Show resolved
Hide resolved
| if (platform === 'android') { | ||
| return defaultOutputPathForAndroid(baseOutputPath); | ||
| return defaultOutputPathForAndroid( | ||
| baseOutputPath != null && baseOutputPath.length > 0 |
Contributor
There was a problem hiding this comment.
baseOutputPath can't be null anymore here, right?
| if (platform === 'ios') { | ||
| return defaultOutputPathForIOS(baseOutputPath); | ||
| return defaultOutputPathForIOS( | ||
| baseOutputPath != null && baseOutputPath.length > 0 |
Contributor
There was a problem hiding this comment.
baseOutputPath can't be null anymore here, right?
packages/react-native/scripts/codegen/generate-artifacts-executor/utils.js
Outdated
Show resolved
Hide resolved
packages/react-native/scripts/codegen/generate-artifacts-executor/utils.js
Outdated
Show resolved
Hide resolved
packages/react-native/scripts/codegen/generate-artifacts-executor/utils.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Riccardo Cipolleschi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The argument for the output path to this CLI has always been optional, but the types didn't reflect this, which caused a few regressions in recent changes (e.g. #53503)
We should default to the
projectRootas implied bycomputeOutputPath.Resolves #54473
Changelog:
[GENERAL] [FIXED] - Ensure codegen CLI supports unspecified
--outputPathargumentTest Plan:
react-native codegeninrn-tester